On Mon, 4 Aug 2014, Vittorio Giovara wrote:
On Sun, Aug 3, 2014 at 9:34 PM, Diego Biurrun <[email protected]> wrote:
---
This probably requires some sort of version adjustment or so...
libavutil/imgutils.h | 2 --
libavutil/internal.h | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h
index 313037a..50fa815 100644
--- a/libavutil/imgutils.h
+++ b/libavutil/imgutils.h
@@ -143,8 +143,6 @@ int av_image_check_size(unsigned int w, unsigned int h, int
log_offset, void *lo
*/
int av_image_check_sar(unsigned int w, unsigned int h, AVRational sar);
-int avpriv_set_systematic_pal2(uint32_t pal[256], enum AVPixelFormat pix_fmt);
-
/**
* @}
*/
diff --git a/libavutil/internal.h b/libavutil/internal.h
index 210c524..067c6ca 100644
--- a/libavutil/internal.h
+++ b/libavutil/internal.h
@@ -37,6 +37,7 @@
#include "config.h"
#include "attributes.h"
#include "dict.h"
+#include "pixfmt.h"
#if ARCH_X86
# include "x86/emms.h"
@@ -219,4 +220,6 @@ void avpriv_request_sample(void *avc,
*/
int avpriv_open(const char *filename, int flags, ...);
+int avpriv_set_systematic_pal2(uint32_t pal[256], enum AVPixelFormat pix_fmt);
+
#endif /* AVUTIL_INTERNAL_H */
I don't like it there either, but it's better as is than including
private lavu headers in lavc in my opinion.
Quite on the contrary. The fact that lavc depends on avpriv fucntions from
libavutil is a bad thing yes, but let's not make a bad thing even worse by
exposing that avpriv function in a public header. Including a private
header from lavu to get the already-intended private function is a step in
the right direction.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
