On Wed, Aug 6, 2014 at 7:20 AM, Luca Barbato <[email protected]> wrote:
> On 06/08/14 13:08, Reinhard Tartler wrote:
>> On Tue, Aug 5, 2014 at 11:01 PM, Luca Barbato <[email protected]> wrote:
>>> ---
>>> libavformat/mpegenc.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
>>> index 375915e..500ea48 100644
>>> --- a/libavformat/mpegenc.c
>>> +++ b/libavformat/mpegenc.c
>>> @@ -841,7 +841,8 @@ static int flush_packet(AVFormatContext *ctx, int
>>> stream_index,
>>> /* output data */
>>> assert(payload_size - stuffing_size <= av_fifo_size(stream->fifo));
>>> av_fifo_generic_read(stream->fifo, ctx->pb,
>>> - payload_size - stuffing_size, &avio_write);
>>> + payload_size - stuffing_size,
>>> + (void (*)(void*, void*, int))avio_write);
>>> stream->bytes_to_iframe -= payload_size - stuffing_size;
>>> } else {
>>> payload_size =
>>> --
>>
>> I believe introducing a typedef might make the code a bit more
>> readable.
>
> Though about it, but it is Libav12 material.
I was more thinking about a typedef local to this file.
You are right, the clean, full-fledged solution, i.e., introducing a
typedef to the API, is cleaner but requires management/paperwork such
documentation, etc..
>> The commit message could be a tad more specific (say
>> "compiler warning" instead of "warning" - I was expecting a change
>> that no longer calls av_log first).
>
> Message locally amended.
>
Sure, I believe the patch is fine, otherwise.
--
regards,
Reinhard
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
