On Fri, Aug 08, 2014 at 10:23:49AM +0200, Hendrik Leppkes wrote:
> On Wed, Aug 6, 2014 at 1:46 PM, Diego Biurrun <[email protected]> wrote:
> > ---
> >  libavformat/mpegtsenc.c | 21 ++++++++++++++++++---
> >  1 file changed, 18 insertions(+), 3 deletions(-)
> 
> Was this reviewed before pushing? Didn't see a OK here.

Yes, Luca OKed the whole set.

> > --- a/libavformat/mpegtsenc.c
> > +++ b/libavformat/mpegtsenc.c
> > @@ -430,9 +430,15 @@ static MpegTSService *mpegts_add_service(MpegTSWrite 
> > *ts, int sid,
> >          return NULL;
> >      service->pmt.pid       = ts->pmt_start_pid + ts->nb_services;
> >      service->sid           = sid;
> > +    service->pcr_pid       = 0x1fff;
> >      service->provider_name = av_strdup(provider_name);
> >      service->name          = av_strdup(name);
> > -    service->pcr_pid       = 0x1fff;
> > +    if (!service->provider_name || !service->name) {
> > +        free(service->provider_name);
> > +        free(service->name);
> > +        free(service);
> > +        return NULL;
> > +    }
> 
> av_free

Good catch, thanks, will fix in a moment.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to