On 08/09/2014 01:42 PM, Diego Biurrun wrote:
> On Sat, Aug 09, 2014 at 09:25:36AM -0700, John Stebbins wrote:
>> --- a/libavcodec/mpegvideo.c
>> +++ b/libavcodec/mpegvideo.c
>> @@ -379,7 +379,6 @@ av_cold int ff_dct_common_init(MpegEncContext *s)
>> {
>> ff_blockdsp_init(&s->bdsp, s->avctx);
>> ff_hpeldsp_init(&s->hdsp, s->avctx->flags);
>> - ff_idctdsp_init(&s->idsp, s->avctx);
>> ff_me_cmp_init(&s->mecc, s->avctx);
>> ff_mpegvideodsp_init(&s->mdsp);
>> ff_videodsp_init(&s->vdsp, s->avctx->bits_per_raw_sample);
> I wonder if some of the places where ff_dct_common_init is called should
> be replaced by just ff_idct_common_init now.
This would take some research to determine. But I can probably do a quick
smoke test by removing the calls and see what
breaks in fate.
>> @@ -403,6 +402,13 @@ av_cold int ff_dct_common_init(MpegEncContext *s)
>> if (ARCH_X86)
>> ff_MPV_common_init_x86(s);
>>
>> + return 0;
>> +}
>> +
>> +av_cold void ff_idct_common_init(MpegEncContext *s, AVCodecContext *avctx)
>> +{
>> + ff_idctdsp_init(&s->idsp, avctx);
>> +
>> /* load & permutate scantables
>> * note: only wmv uses different ones
>> */
> ff_dct_common_init takes the avctx from mpegenccontext, is there a reason
> to pass a second parameter here?
>
>
Good point. The extra parameter isn't needed. I'll revise that.
--
John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
