On Sun, 10 Aug 2014, Janne Grunau wrote:

On 2014-08-09 22:48:29 +0300, Martin Storsjö wrote:
---
This goes on top of Diego's RFC patch.
---
 configure | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 4d2439e..877f240 100755
--- a/configure
+++ b/configure
@@ -3782,17 +3782,18 @@ if enabled_any arm aarch64 || enabled_all ppc altivec 
&& enabled asm; then
     nogas=:
     enabled_any arm aarch64 && nogas=die
     enabled_all ppc altivec && nogas=warn
+    as_noop=-v

-    case $as_type
-        arm*) gaspp_as_type=armasm ;;
+    case $as_type in
+        arm*) gaspp_as_type=armasm; as_noop=-h ;;
         gcc)  gaspp_as_type=gas ;;
         *)    gaspp_as_type=$as_type ;;
     esac

     [ $target_os = "darwin" ] && gaspp_as_type="apple-$as_type"

-    check_cmd gas-preprocessor.pl -arch $arch -as-type $gaspp_as_type &&
-        gas="gas-preprocessor.pl -arch $arch -as-type $gaspp_as_type $as"
+    check_cmd gas-preprocessor.pl -arch $arch -as-type $gaspp_as_type -- $as $as_noop 
&&
+        gas="gas-preprocessor.pl -arch $arch -as-type $gaspp_as_type -- $as"

tested on linux and darwin with llvm/clang. clang -no-integrated-as gets
misdetected as apple-clang although it uses apple's outdated gnu as.

I'm not sure how we can fix that. In practice this doesn't matter since
-as-type apple-gas and apple-clang doesn't seem to make a difference.
Also Xcode 5.1's 'clang -no-integrated-as' can't be used as compiler
since it produces asm apple's gas can't handle.

I have no setup to test apple's gcc-4.2 with gas.

Tested, almost works, requires the following fixup:

-    [ $target_os = "darwin" ] && gaspp_as_type="apple-$as_type"
+    [ $target_os = "darwin" ] && gaspp_as_type="apple-$gaspp_as_type"

With that, all in all, all issues related to these patches should be resolved, and all of it can be pushed, no?

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to