On Mon, Aug 11, 2014 at 07:36:48AM -0700, John Stebbins wrote:
> --- a/libavcodec/mpeg12dec.c
> +++ b/libavcodec/mpeg12dec.c
> @@ -1097,18 +1097,16 @@ static av_cold int mpeg_decode_init(AVCodecContext
> *avctx)
> {
> Mpeg1Context *s = avctx->priv_data;
> MpegEncContext *s2 = &s->mpeg_enc_ctx;
> - int i;
> -
> - /* we need some permutation to store matrices,
> - * until MPV_common_init() sets the real permutation. */
> - for (i = 0; i < 64; i++)
> - s2->idsp.idct_permutation[i] = i;
>
> ff_MPV_decode_defaults(s2);
>
> s->mpeg_enc_ctx.avctx = avctx;
> s->mpeg_enc_ctx.flags = avctx->flags;
> s->mpeg_enc_ctx.flags2 = avctx->flags2;
> +
> + /* we need some permutation to store matrices,
> + * until ff_mpv_idct_init() sets the real permutation. */
> + ff_mpv_idct_init(s2);
> ff_mpeg12_common_init(&s->mpeg_enc_ctx);
> ff_mpeg12_init_vlcs();
This bit looks suspicious; at least the comment does no longer match
the code.
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -700,6 +700,7 @@ av_cold int ff_MPV_encode_init(AVCodecContext *avctx)
> s->alternate_scan);
>
> /* init */
> + ff_mpv_idct_init(s);
> if (ff_MPV_common_init(s) < 0)
> return -1;
Does this file really need the IDCT init?
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
