On Mon, 18 Aug 2014 17:28:23 -0400, Andrew Stone <[email protected]> wrote: > This reverts commit 30e50c50274f88f0f5ae829f401cd3c7f5266719. > > The original commit broke the ability to stream AAC over HTTP/Icecast. It > looks > like avformat_find_stream_info() gets stuck in an infinite loop, never hitting > AVFormatContext.max_analyze_duration since duration is never set for any of > the packets. > > Example stream: http://listen.classicrocklounge.com:8000/aac64 > --- > > The original commit message also says that use of AVCodecContext.frame_size is > discouraged, but the documentation on the field says, "may be set by some > decoders to indicate constant frame size". Should the documentation around > this > field be updated, or was that just a mistake? >
It's not that there's something wrong with frame_size itself, but using it _from libavformat_ is evil. Because it's only set by encoder or decoders, which means that in lavf it will only be set when the stream codec context is used as the encoding or decoding context (which is the thing that's discouraged). As for the revert, I have a hopefully better patch locally, but it uncovers some unrelated bugs which I hope to fix tomorrow. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
