Your mailer mangles lines something fierce - maybe get another one?

On Tue, Sep 02, 2014 at 01:39:42PM -0400, Gabriel Dume wrote:
> On Tue, Sep 2, 2014 at 6:32 AM, Diego Biurrun <[email protected]> wrote:
> > On Mon, Sep 01, 2014 at 03:19:01PM -0400, Gabriel Dume wrote:
> > > --- a/libavcodec/wmv2.c
> > > +++ b/libavcodec/wmv2.c
> > > @@ -51,84 +52,87 @@ av_cold void ff_wmv2_common_init(Wmv2Context * w){
> > > -    case 1:
> > > -        ff_simple_idct84_add(dst           , stride, block1);
> > > -        ff_simple_idct84_add(dst + 4*stride, stride, w->abt_block2[n]);
> > > -    case 2:
> > > -        ff_simple_idct48_add(dst           , stride, block1);
> > > -        ff_simple_idct48_add(dst + 4       , stride, w->abt_block2[n]);
> > > +      case 1:
> > > +          ff_simple_idct84_add(dst             , stride, block1);
> > > +          ff_simple_idct84_add(dst + 4 * stride, stride,
> > w->abt_block2[n]);
> > > +      case 2:
> > > +          ff_simple_idct48_add(dst           , stride, block1);
> > > +          ff_simple_idct48_add(dst + 4       , stride,
> > w->abt_block2[n]);
> >
> > Get rid of the stray spaces before comma.
> >
> > > -    wmv2_add_block(w, block1[0], dest_y                    ,
> > s->linesize, 0);
> > > -    wmv2_add_block(w, block1[1], dest_y + 8                ,
> > s->linesize, 1);
> > > +    wmv2_add_block(w, block1[0], dest_y                      ,
> > s->linesize, 0);
> > > +    wmv2_add_block(w, block1[1], dest_y + 8                  ,
> > s->linesize, 1);
> >
> > same
> >
> > > -    wmv2_add_block(w, block1[4], dest_cb                   ,
> > s->uvlinesize, 4);
> > > -    wmv2_add_block(w, block1[5], dest_cr                   ,
> > s->uvlinesize, 5);
> > > +    wmv2_add_block(w, block1[4], dest_cb                     ,
> > s->uvlinesize, 4);
> > > +    wmv2_add_block(w, block1[5], dest_cr                     ,
> > s->uvlinesize, 5);
> >
> > ditto
> 
> 
>     w->wdsp.put_mspel_pixels_tab[dxy](dest_y,                    ptr,
>                   linesize);
>     w->wdsp.put_mspel_pixels_tab[dxy](dest_y     + 8,            ptr
>   + 8,            linesize);
>     w->wdsp.put_mspel_pixels_tab[dxy](dest_y     + 8 * linesize, ptr
>   + 8 * linesize, linesize);
>     w->wdsp.put_mspel_pixels_tab[dxy](dest_y + 8 + 8 * linesize, ptr +
> 8 + 8 * linesize, linesize);
> 
> how about this part? should i get rid of the spaces here too?

No, this part has no spaces before comma.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to