On Thu, Sep 04, 2014 at 06:22:14PM -0400, Gabriel Dume wrote:
> --- a/libavcodec/dirac.c
> +++ b/libavcodec/dirac.c
> @@ -61,20 +61,20 @@ static const dirac_source_params
> dirac_source_parameters_defaults[] = {
>
> /* [DIRAC_STD] Table 10.4 - Available preset pixel aspect ratio values */
> static const AVRational dirac_preset_aspect_ratios[] = {
> - {1, 1},
> - {10, 11},
> - {12, 11},
> - {40, 33},
> - {16, 11},
> - {4, 3},
> + { 1, 1 },
> + { 10, 11 },
> + { 12, 11 },
> + { 40, 33 },
> + { 16, 11 },
> + { 4, 3 },
> };
It looks odd to only right-align the left column.
> static const AVRational dirac_frame_rate[] = {
> - {15000, 1001},
> - {25, 2},
> + { 15000, 1001 },
> + { 25, 2 },
> };
If you feel extra motivated, you could align some more here.
> --- a/libavcodec/dirac_parser.c
> +++ b/libavcodec/dirac_parser.c
> @@ -162,8 +161,8 @@ static int dirac_combine_frame(AVCodecParserContext *s,
> AVCodecContext *avctx,
> if (!unpack_parse_unit(&pu1, pc, pc->index - 13)
> ||
> !unpack_parse_unit(&pu, pc, pc->index - 13 - pu1.prev_pu_offset)
> ||
> pu.next_pu_offset != pu1.prev_pu_offset) {
> - pc->index -= 9;
> - *buf_size = next-9;
> + pc->index -= 9;
> + *buf_size = next-9;
spaces around -
> @@ -217,27 +216,24 @@ static int dirac_parse(AVCodecParserContext *s,
> AVCodecContext *avctx,
> } else {
> next = find_frame_end(pc, buf, buf_size);
> - if (!pc->is_synced && next == -1) {
> - /* No frame start found yet. So throw away the entire buffer. */
> - return buf_size;
> - }
> + if (!pc->is_synced && next == -1)
> + return buf_size; /* No frame start found yet. So throw away the
> entire buffer. */
Before was fine I think, it also kept line length below 80 characters.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
