On Thu, Sep 04, 2014 at 04:11:15PM +0300, Rémi Denis-Courmont wrote:
> --- a/libavcodec/vdpau.c
> +++ b/libavcodec/vdpau.c
> @@ -38,6 +40,67 @@
>
> +static VdpStatus vdp_enosys(/* Unspecified, not void - leave empty */)
The comment puzzles me. Also, doesn't this add a warning?
> +#if FF_API_DECODER_VDPAU
> + if (hwctx->device == VDP_INVALID_HANDLE) {
> + vdctx->decoder = hwctx->decoder;
> + vdctx->render = hwctx->render;
nit: align =
> @@ -133,7 +197,25 @@ do { \
> +AVVDPAUContext *av_vdpau_create_context(VdpDevice device,
> + VdpGetProcAddress *get_proc_address)
> +{
> + AVVDPAUContext *hwctx = av_mallocz(sizeof(AVVDPAUContext));
> + if (!hwctx)
> + return NULL;
> +
> + hwctx->device = device;
> + hwctx->get_proc_address = get_proc_address;
nit: align =
> --- a/libavcodec/vdpau.h
> +++ b/libavcodec/vdpau.h
> @@ -92,8 +94,9 @@ typedef struct AVVDPAUContext {
> *
> * Set by the user.
> */
> + attribute_deprecated
> VdpDecoderRender *render;
> -
> +#endif
> #if FF_API_BUFS_VDPAU
> /**
> * VDPAU picture information
Please comment the endif, there are several #if blocks in this file already.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
