On Tue, Sep 16, 2014 at 05:04:05PM +0100, Vittorio Giovara wrote:
> --- a/libavformat/rtspdec.c
> +++ b/libavformat/rtspdec.c
> @@ -358,8 +358,11 @@ static inline int parse_command_line(AVFormatContext *s, 
> const char *line,
>  {
>      RTSPState *rt = s->priv_data;
> -    const char *linept, *searchlinept;
> -    linept = strchr(line, ' ');
> +    const char *searchlinept;
> +    const char *linept = strchr(line, ' ');
> +    if (!linept)
> +        return AVERROR_INVALIDDATA;

LGTM

However, I'll play the curmudgeon now and point out that this is not the
only case of strchr use w/o checking the return value.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to