On 17/09/14 00:06, Andrew Kelley wrote:
>>> + if (size > INT32_MAX - FF_INPUT_BUFFER_PADDING_SIZE) {
>>> + av_log(s, AV_LOG_ERROR, "APE tag size too large.\n");
>>> + return AVERROR_INVALIDDATA;
>>> + }
> It is used as a parameter like this: int avio_read(AVIOContext *s, unsigned
> char *buf, int size);
> This makes the maximum acceptable value INT_MAX.
> In the spirit of having the maximum input range the same across platforms,
> INT32_MAX is used instead of INT_MAX. FF_INPUT_BUFFER_PADDING_SIZE is
> subtracted due to code like this:
> av_malloc(size + FF_INPUT_BUFFER_PADDING_SIZE);
Correct.
> I do not understand your objection to this code, Diego. Clearly comparing
> against UINT_MAX is incorrect, and this patch is strictly better than
> status quo.
Diego probably didn't read the code below. One of the wishlist items for
plaid is to provide git integration to the point you get:
1- If the patch applies correctly to master.
2- Expand the patchview so it shows you the whole file.
lu - wishing to have enough time to complete plaid now
PS: People with experience with python are welcome to help the code is
in github.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
