2014-09-19 1:10 GMT+02:00 Anton Khirnov <[email protected]>:
>
> On Tue, 16 Sep 2014 22:09:16 +0300, =?UTF-8?Q?R=C3=A9mi_Denis-Courmont?=
> <[email protected]> wrote:
>> Le 2014-09-16 21:52, Rémi Denis-Courmont a écrit :
>> >> Proper naming please, camelcased with typedeffed struct.
>> >
>> > That is the proper naming as far as it matches the convention
>> > established by the libavcodec VDA support.
>>
>> Also dxva_context and vaapi_context, and dxva2_picture_context and
>> vpdau_picture_context.
>
> Because the person who wrote the initial hwaccel implementation did not follow
> the naming conventions (and the reviewer(s) did not notice/care) and the
> others
> cargoculted from him.
Do you remember the XvMC Deathmatch? If so, I don't remember anybody
who really voiced against xvmc_render_state. Then, it was legitimate
to think after that, that the naming conventions where in place for
that kind of stuff, wasn't it? Especially when this passes Diego's
parser. But, I don't really remember the finest details myself, do
you?
Having said that, I am all for typedef struct <hwaccel>_context { ...
} AV<HWACCEL>Context; for consistency with the rest.
>> Not to mention non-hwaccel stuff.
>
> Most non-hwaccel stuff follows the rules these days.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
