On Sun, 21 Sep 2014, Diego Biurrun wrote:

This reduces TMPDIR pollution and possibly avoids race conditions with
temporary files that are not atomically created.

Based on a patch from Michał Górny <[email protected]>.
---

Rewritten to be less intrusive.

configure | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 59dd453..ea3244c 100755
--- a/configure
+++ b/configure
@@ -2593,15 +2593,18 @@ if ! check_cmd mktemp -u XXXXXX; then
    }
fi

+AVTMPDIR=$(mktemp -u "${TMPDIR}/avconf.XXXXXXXX" 2> /dev/null)
+
+mkdir $AVTMPDIR || die "Unable to create temporary directory in $TMPDIR."
+
tmpfile(){
-    tmp=$(mktemp -u "${TMPDIR}/ffconf.XXXXXXXX")$2 &&
-        (set -C; exec > $tmp) 2>/dev/null ||
+    tmp=${AVTMPDIR}/avconf$2
+    (set -C; exec > $tmp) 2> /dev/null ||
        die "Unable to create temporary file in $TMPDIR."
-    append TMPFILES $tmp
    eval $1=$tmp
}

-trap 'rm -f -- $TMPFILES' EXIT
+trap 'rm -rf -- "$AVTMPDIR"' EXIT

tmpfile TMPASM .asm
tmpfile TMPC   .c
--
1.9.1

Does this still respect the TMPDIR variable as it did before? This is necessary to be able to run MSVC 2013 without needing c99conv for fixing windows vs msys path names.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to