Quoting Vittorio Giovara (2014-09-29 21:05:49) > On Mon, Sep 29, 2014 at 7:54 PM, Anton Khirnov <[email protected]> wrote: > > Quoting Vittorio Giovara (2014-09-29 15:29:12) > >> --- > >> AVCOL_SPC_RGB should be actually AVCOL_SPC_GBR, but specs are fuzzy on > >> that too, > >> they report "Matrix GBR - Typically referred to as RGB", so I just mention > >> that > >> in the comment. > >> The alternative is either to add an alias or start the deprecation dance. > >> Opinions? > > > > Not worth it IMO. Just expanding doxy is fine. > > Agreed. > > > The commit message should be changed though, you're not adding any > > synonyms that I see. You're extending/adding doxy. > > I considered a synonym something like > + AVCOL_PRI_BT470M = 4, ///< also FCC Title 47 Code of Federal > Regulations 73.682 (a)(20) > > Would "doc: expand description for some color properties" fit better? >
Yes, that's fine with me. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
