On Sat, Oct 4, 2014 at 12:53 PM, Luca Barbato <[email protected]> wrote:
> ---
>  libavcodec/Makefile    |    2 +-
>  libavcodec/vc1_block.c | 5240 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vc1dec.c    | 5197 -----------------------------------------------
>  3 files changed, 5241 insertions(+), 5198 deletions(-)
>  create mode 100644 libavcodec/vc1_block.c

OK

(only cosmetic comments, feel free to apply or reject them before pushing)

> new file mode 100644
> index 0000000..28bc2e9
> --- /dev/null
> +++ b/libavcodec/vc1_block.c
> +
> +#include "internal.h"
> +#include "avcodec.h"
> +#include "error_resilience.h"
> +#include "mpeg_er.h"
> +#include "mpegutils.h"
> +#include "mpegvideo.h"
> +#include "h263.h"
> +#include "h264chroma.h"
> +#include "qpeldsp.h"
> +#include "vc1.h"
> +#include "vc1data.h"
> +#include "vc1acdata.h"
> +#include "msmpeg4data.h"
> +#include "unary.h"
> +#include "mathops.h"

extra karma if you order the headers

> +#undef NDEBUG
> +#include <assert.h>
> +
> +#define MB_INTRA_VLC_BITS 9
> +#define DC_VLC_BITS 9
> +
> +

stray line?

> +            stride_y       = s->linesize << fieldtx;
> +            v_dist         = (16 - fieldtx) >> (fieldtx == 0);

uncrustify artefact

> +            stride_y   = s->linesize << fieldtx;
> +            v_dist     = fieldtx ? 15 : 8;

same



-- 
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to