Quoting Vittorio Giovara (2014-10-14 17:46:42)
> From: Luca Barbato <[email protected]>
> 
> The element is always valid.
> 
> CC: [email protected]
> Bug-Id: CID 732276
> ---
>  avprobe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/avprobe.c b/avprobe.c
> index 12524f2..4fe91dd 100644
> --- a/avprobe.c
> +++ b/avprobe.c
> @@ -181,7 +181,7 @@ static void ini_print_object_header(const char *name)
>      }
>  
>      avio_printf(probe_out, "%s", name);
> -    if (el && el->type == ARRAY)
> +    if (el->type == ARRAY)
>          avio_printf(probe_out, ".%"PRId64"", el->nb_elems);
>      avio_printf(probe_out, "]\n");
>  }
> -- 
> 1.9.3 (Apple Git-50)
> 

Looks ok.

At the very least, that pointer is accessed before, so it's too late to
check it there.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to