On 18/10/14 17:58, Vittorio Giovara wrote:
From: Michael Niedermayer <[email protected]>

CC: [email protected]
Bug-Id: CID 1135748
---
  libavformat/hdsenc.c | 15 ++++++++++++---
  1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/libavformat/hdsenc.c b/libavformat/hdsenc.c
index 53fef33..f41381d 100644
--- a/libavformat/hdsenc.c
+++ b/libavformat/hdsenc.c
@@ -204,7 +204,10 @@ static int write_manifest(AVFormatContext *s, int final)
      avio_printf(out, "</manifest>\n");
      avio_flush(out);
      avio_close(out);
-    rename(temp_filename, filename);
+    if (rename(temp_filename, filename) == -1) {
+        av_log(s, AV_LOG_ERROR, "failed to rename file %s to %s\n", 
temp_filename, filename);
+        return AVERROR(errno);

wrong, errno gets reset by av_log and you return 0;

+    }
      return 0;
  }

@@ -286,7 +289,10 @@ static int write_abst(AVFormatContext *s, OutputStream 
*os, int final)
      update_size(out, afrt_pos);
      update_size(out, 0);
      avio_close(out);
-    rename(temp_filename, filename);
+    if (rename(temp_filename, filename) == -1) {
+        av_log(s, AV_LOG_ERROR, "failed to rename file %s to %s\n", 
temp_filename, filename);
+        return AVERROR(errno);

Same thing.

+    }
      return 0;
  }

@@ -481,7 +487,10 @@ static int hds_flush(AVFormatContext *s, OutputStream *os, 
int final,

      snprintf(target_filename, sizeof(target_filename),
               "%s/stream%dSeg1-Frag%d", s->filename, index, 
os->fragment_index);
-    rename(os->temp_filename, target_filename);
+    if (rename(os->temp_filename, target_filename) == -1) {
+        av_log(s, AV_LOG_ERROR, "failed to rename file %s to %s\n", 
os->temp_filename, target_filename);
+        return AVERROR(errno);

Same thing.

+    }
      add_fragment(os, target_filename, os->frag_start_ts, end_ts - 
os->frag_start_ts);

      if (!final) {


_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to