Quoting Luca Barbato (2014-10-21 15:21:57)
> ---
>  avconv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/avconv.c b/avconv.c
> index dc21aff..70ddd29 100644
> --- a/avconv.c
> +++ b/avconv.c
> @@ -1070,6 +1070,8 @@ static void do_streamcopy(InputStream *ist, 
> OutputStream *ost, const AVPacket *p
>  
>      av_init_packet(&opkt);
>  
> +    av_packet_copy_props(&opkt, pkt);
> +

The concept is ok, but the implementation could use some polish.

1) the copy involves mallocs, so it can fail
2) this function can fail after this point, then you'll leak the side
data.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to