On 08/11/14 08:15, Anton Khirnov wrote:
Quoting Vittorio Giovara (2014-10-30 01:52:01)
Bug-Id: CID 732291
---
  libavcodec/aacdec.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c
index 498b278..cc74bd6 100644
--- a/libavcodec/aacdec.c
+++ b/libavcodec/aacdec.c
@@ -624,6 +624,9 @@ static void decode_channel_map(uint8_t layout_map[][3],
          case AAC_CHANNEL_LFE:
              syn_ele = TYPE_LFE;
              break;
+        default:
+            // AAC_CHANNEL_OFF has no channel map
+            return;
          }
          layout_map[0][0] = syn_ele;
          layout_map[0][1] = get_bits(gb, 4);
--
1.9.3 (Apple Git-50)


This function is never called with other types than those hanled in the
switch. So I think an assert would be appropriate there.


In this specific case an unreachable marker seems a good idea.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to