On Sun, Nov 9, 2014 at 11:20 AM, Martin Storsjö <[email protected]> wrote: > On Sun, 9 Nov 2014, Vittorio Giovara wrote: > >> CC: [email protected] >> Bug-Id: CID 1198260 >> --- >> libavcodec/png_parser.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/png_parser.c b/libavcodec/png_parser.c >> index d07f288..c66caf3 100644 >> --- a/libavcodec/png_parser.c >> +++ b/libavcodec/png_parser.c >> @@ -36,7 +36,7 @@ typedef struct PNGParseContext { >> ParseContext pc; >> >> int chunk_pos; ///< position inside current chunk >> - int chunk_length; ///< length of the current chunk >> + uint32_t chunk_length; ///< length of the current chunk >> int remaining_size; ///< remaining size of the current chunk >> } PNGParseContext; >> >> -- >> 1.9.3 (Apple Git-50) > > > So, what's the bug that this fixes? Yes, it's probably right, and the > coverity reference probably explains it, but commit messages should be > understandable on their own, not require looking up external references > which might no longer be available when you want to look into it later.
Right, this fixes the comparison "ppc->chunk_length > 0x7fffffff" on line 82. I've locally added Fixes the comparison against constant value 0x7fffffff. Is it ok? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
