On Sat, Nov 15, 2014 at 1:13 PM, Anton Khirnov <[email protected]> wrote: > Quoting Vittorio Giovara (2014-11-15 12:54:33) >> On Thu, Nov 13, 2014 at 9:43 PM, Anton Khirnov <[email protected]> wrote: >> > Quoting Vittorio Giovara (2014-11-05 15:43:44) >> >> On Wed, Nov 5, 2014 at 6:58 AM, Anton Khirnov <[email protected]> wrote: >> >> > Quoting Vittorio Giovara (2014-11-04 15:36:56) >> >> >> CC: [email protected] >> >> >> Bug-Id: CID 1238835 >> >> >> --- >> >> >> libavcodec/mpegaudio_tablegen.h | 4 ++-- >> >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> >> >> >> diff --git a/libavcodec/mpegaudio_tablegen.h >> >> >> b/libavcodec/mpegaudio_tablegen.h >> >> >> index 8a3e51a..110d4f2 100644 >> >> >> --- a/libavcodec/mpegaudio_tablegen.h >> >> >> +++ b/libavcodec/mpegaudio_tablegen.h >> >> >> @@ -44,9 +44,9 @@ static void mpegaudio_tableinit(void) >> >> >> { >> >> >> int i, value, exponent; >> >> >> for (i = 1; i < TABLE_4_3_SIZE; i++) { >> >> >> - double value = i / 4; >> >> >> double f, fm; >> >> >> int e, m; >> >> >> + value = i / 4; >> >> > >> >> > Eh? The code now does something completely different. >> >> >> >> Umh in what sense? >> > >> > Currently, value is double. After your patch it will be an int. >> >> it is double, but then it cast to double again, so it make me wonder >> that the original intent was to use the integer version of that >> variable. > > This does not make sense to me.
first there is 'int value', then there is 'double value = i/4', then there is a for loop with 'value' using integer values only then there is a cast of 'value' to double indeed, the current code does not make any sense or at least it is more complicated than it needs to be, let's try to fix this? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
