On 27/11/14 3:03 PM, Reinhard Tartler wrote:
> On Thu, Nov 27, 2014 at 12:59 PM, James Almer <jamr...@gmail.com> wrote:
>> On 27/11/14 2:43 PM, Reinhard Tartler wrote:
>>> Hi,
>>>
>>> it seems that tests/lena.pnm is not really redistributable. I'm
>>> proposing to replace it with an image I've taken this summer. The
>>> patch itself is too large to post it here, which is why I've uploaded
>>> it to https://github.com/libav/libav/pull/17.
>>>
>>> Luca seems okay with it, koda suggested to ask here anyways.
>>>
>>> OK to push to master? any suggestions for the commit message?
>>>
>>> Reinhard
>>
>> Isn't it cleaner to just upload lena to the fate suit instead of having to
>> update the reference files for all the relevant tests?
> 
> How is that cleaner than replacing non-redistributable files with a
> perfectly free one?

Cleaner commit. It would be a matter of changing the path of lena.pnm to the 
samples 
directory. A couple lines change.

> 
> Moving it to fate ensures that no tests can be executed without fate
> (currently, there are some).

vsynth and asynth dependent tests would still run without the fate suit.

Anyway, just my 2 cents.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to