Quoting Luca Barbato (2014-11-30 11:57:39)
> On 30/11/14 11:46, Anton Khirnov wrote:
> > Quoting Vittorio Giovara (2014-11-29 17:51:20)
> >> From: Dave Rice <[email protected]>
> >>
> >> This avoids duplication and makes tags more clear.
> >>
> >> Signed-off-by: Vittorio Giovara <[email protected]>
> >> ---
> >>   libavformat/mov.c | 8 ++++----
> >>   1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/libavformat/mov.c b/libavformat/mov.c
> >> index 672b993..6310286 100644
> >> --- a/libavformat/mov.c
> >> +++ b/libavformat/mov.c
> >> @@ -313,12 +313,12 @@ static int mov_read_udta_string(MOVContext *c, 
> >> AVIOContext *pb, MOVAtom atom)
> >>       case MKTAG(0xa9,'A','R','T'): key = "artist";                        
> >> break;
> >>       case MKTAG(0xa9,'P','R','D'): key = "producer";                      
> >> break;
> >>       case MKTAG(0xa9,'a','l','b'): key = "album";                         
> >> break;
> >> -    case MKTAG(0xa9,'a','u','t'): key = "artist";                        
> >> break;
> >> +    case MKTAG(0xa9,'a','u','t'): key = "author";                        
> >> break;
> >
> > At least this looks very very very wrong to me. The standard key is
> > 'artist'. That's what the client programs will expect. Using random
> > other terms does not make anything "more clear".
> >
> > Does it happen in practice that both tags are set to different values?
> > Is there any semantic difference between them?
> >
> 
> Not sure if they have a `performer` tag but usually you have `artist` 
> for the performer and author for whoever wrote the music. (think about 
> classic music).
> 

The standard tag for that is 'composer'.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to