On 02/12/14 15:58, Vittorio Giovara wrote:
--- Not sure if asserts are acceptable, thoughts? Vitoriolibavfilter/vf_interlace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_interlace.c b/libavfilter/vf_interlace.c index 3e2a044..0b2444c 100644 --- a/libavfilter/vf_interlace.c +++ b/libavfilter/vf_interlace.c @@ -141,7 +141,7 @@ static void copy_picture_field(InterlaceContext *s, uint8_t *dstp = dst_frame->data[plane]; const uint8_t *srcp = src_frame->data[plane]; - av_assert0(cols >= 0); + av_assert0(cols >= 0 || lines >= 0); lines = (lines + (field_type == FIELD_UPPER)) / 2; if (field_type == FIELD_LOWER)
The asserts should go away if they are reachable. but given which is the specific code and usage pattern I won't complain too loudly.
lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
