Am 02.12.2014 um 15:04 schrieb Vittorio Giovara:
> On Tue, Dec 2, 2014 at 7:11 AM, Oleksij Rempel <[email protected]> wrote:
>> Am 01.12.2014 um 15:54 schrieb Vittorio Giovara:
>>> On Tue, Nov 25, 2014 at 11:04 AM, Oleksij Rempel <[email protected]> 
>>> wrote:
>>>> Oleksij Rempel (7):
>>>>   lavc: dss: fix Uninitialized scalar variable warning
>>>>   lavc: dss: return error insted of invalid buffer size
>>>>   lavc: dss: set CODEC_CAP_DR1
>>>>   lavf: dss: fix error checking and formating
>>>>   lavf: dss: alloc buffer only once.
>>>>   lavf: dss: test 723_1 stream for invalid data
>>>>   lavf: dss: test dss_sp stream for invalid data
>>>>
>>>>  libavcodec/dss_sp_dec.c |  5 ++--
>>>>  libavformat/dss.c       | 64 
>>>> ++++++++++++++++++++++++++++++++-----------------
>>>>  2 files changed, 45 insertions(+), 24 deletions(-)
>>>
>>> Hi Oleksij,
>>> did you check if lp playback support works for you
>>
>> yes it works for me.
>>
>>> and that this
>>> feature is intended?
>>
>> am... i'm not sure what do you mean.
> 
> I mean, is there any reason for calling the decoder DSS_SP if it
> supports SP and LP correctly?

No. The DSS_SP decoder supports only SP mode. LP mode is G723.1 muxed in
to DSS container. This is why i don't really won't to rename dss_sp to
dss. It's already confusing.

> I'd rather have it named just DSS and dss.c for brevity and clarity,
> if you agree.
> --
> Vittorio
> 


-- 
Regards,
Oleksij

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to