On 07/01/15 12:43, Jean-Baptiste Kempf wrote:
On 07 Jan, Luca Barbato wrote :
The bound check should be updated (otherwise you can craft evil
packets that read over the buffer).
Sure.
Having branches in loops isn't that nice.
Tbh, I don't see the point.
For me the code is less readable with this split.
"if it does not have alpha make all entries beside the first opaque,
otherwise read the alpha values for each of them"
vs
"for each entry if it has alpha read the value, otherwise make it
opaque, but only if the index entry is different from 0, in that case
set it transparent"
For the rest looks nice to me, if you have a sample I'd like
to test my changes.
http://trailers.divx.com/divx_prod/divx_plus_hd_showcase/ElephantsDream_DivXHD1080p_ASP.divx
Thanks!
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
