On Fri, Dec 19, 2014 at 12:59:15AM +0100, Vittorio Giovara wrote:
>
> Changelog | 1 +
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/avcodec.h | 1 +
> libavcodec/codec_desc.c | 7 +
> libavcodec/dss_sp.c | 791
> ++++++++++++++++++++++++++++++++++++++++++++++++
> libavcodec/version.h | 2 +-
> 7 files changed, 803 insertions(+), 1 deletion(-)
> create mode 100644 libavcodec/dss_sp.c
docs, dude ...
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -201,6 +201,7 @@ OBJS-$(CONFIG_FRWU_DECODER) += frwu.o
> OBJS-$(CONFIG_G2M_DECODER) += g2meet.o mjpeg.o
> OBJS-$(CONFIG_G723_1_DECODER) += g723_1.o acelp_vectors.o \
> celp_filters.o
> +OBJS-$(CONFIG_DSS_SP_DECODER) += dss_sp.o
ahem ...
> --- /dev/null
> +++ b/libavcodec/dss_sp.c
> @@ -0,0 +1,791 @@
> +
> +#include "libavutil/common.h"
> +#include "libavutil/channel_layout.h"
> +#include "libavutil/mem.h"
> +#include "libavutil/opt.h"
> +
> +#include "avcodec.h"
> +#include "internal.h"
> +#include "get_bits.h"
nit: order
> +static void dss_sp_convert_coeffs(LPCData *lpc,
> + int32_t *coeffs)
nit: coalesce lines
> + dss_sp_vec_mult(p->filter, tmp_buf,
> + binary_decreasing_array);
> + dss_sp_shift_sq_add(tmp_buf, p->audio_buf,
> + p->vector_buf);
> +
> + dss_sp_vec_mult(p->filter, tmp_buf,
> + dss_sp_unc_decreasing_array);
> + dss_sp_shift_sq_sub(tmp_buf,
> + p->err_buf1, p->vector_buf);
same
> +static void dss_sp_update_state(DssSpContext *p, int32_t *dst)
> +{
> + int i, offset, counter, a = 0;
> +
> + for (i = 0; i < 6; i++)
> + p->excitation[i] = p->excitation[288 + i];
> +
> + for (i = 0; i < 72 * SUBFRAMES; i++)
> + p->excitation[6 + i] = dst[i];
> +
> + offset = 6;
> + counter = 0;
Initializing here and not at declaration looks odd.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
