On Tue, Jan 13, 2015 at 3:16 PM, Luca Barbato <[email protected]> wrote: > On 13/01/15 14:56, Vittorio Giovara wrote: >> On Wed, Dec 17, 2014 at 5:36 PM, Vittorio Giovara >> <[email protected]> wrote: >>> On Wed, Dec 17, 2014 at 5:21 PM, Luca Barbato <[email protected]> wrote: >>>> On 17/12/14 16:02, Vittorio Giovara wrote: >>>>> >>>>> --- >>>>> libavcodec/dvbsubdec.c | 88 >>>>> +++++++++++++++++++++++++++++++++----------------- >>>>> 1 file changed, 58 insertions(+), 30 deletions(-) >>>>> >>>> break; >>>>> >>>>> case DVBSUB_DISPLAY_SEGMENT: >>>>> - *data_size = dvbsub_display_end_segment(avctx, p, >>>>> segment_length, sub); >>>>> + ret = dvbsub_display_end_segment(avctx, p, >>>>> segment_length, sub); >>>>> + *data_size = ret; >>>> >>>> >>>> >>>> a negative data size might be surprising, is the caller ignoring the value >>>> in that case? >>> >>> that is my assumption yes >>> >>> -- >>> Vittorio >> > > If the assumption is confirmed ok.
Any dvbsubdec user would like to chime in? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
