On 14/01/15 23:20, Martin Storsjö wrote:
On Wed, 14 Jan 2015, Luca Barbato wrote:

On 14/01/15 16:22, Ronald S. Bultje wrote:
And you'll see why 30 is the max. 1 << 31 is undefined for signed
integers.
There is no particular reason why this would be the largest coefficient
that we want to support (really, our storage type is int16_t for 8bit
content so we can't store these coefficients anyway).


Thanks a lot for looking it up.

I'll amend the commit message with something like "30 is the maximum
number of bits that can be read into coeff_abs below.", and push later,
if that seems ok.


The approach seemed ok already I'm not sure we have INT_BITS or such to make self-explaining the code.

Commit anytime.

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to