On Thu, Jan 22, 2015 at 1:40 PM, Akshay Garg <[email protected]> wrote: > Hey Alex, > > Thanks for the reply. I'm glad that there is no functional issue associated > with the warning. It turns out that ffmpeg version of the libavcodec > library silences this warning already (Thanks to Carl Eugen for bringing > this to my notice). Following is a commit that masks the log. So maybe we > need to do something like this in libav. > > commit 1ac606bae60e46522189b678b58a7fb8376046ac > Author: Reimar Döffinger <[email protected]> > Date: Mon Apr 9 21:19:30 2012 +0200 > > aacsbr: silence message for SBR extension "padding". > > Some files contain a few additional, all-0 bits. > Check for that case and don't print incorrect "not supported" > message. > Fixes trac issue #836. > > Signed-off-by: Reimar Döffinger <[email protected]> > > diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c > index 79a0ca2..ea2dcbb 100644 > --- a/libavcodec/aacsbr.c > +++ b/libavcodec/aacsbr.c > @@ -933,7 +933,9 @@ static void read_sbr_extension(AACContext *ac, > SpectralBandReplication *sbr, > } > break; > default: > - av_log_missing_feature(ac->avctx, "Reserved SBR extensions are", > 1); > + // some files contain 0-padding > + if (bs_extension_id || *num_bits_left > 16 || show_bits(gb, > *num_bits_left)) > + av_log_missing_feature(ac->avctx, "Reserved SBR extensions > are", 1); > skip_bits_long(gb, *num_bits_left); // bs_fill_bits > *num_bits_left = 0; > break; > > Let me know if you'd like me to upload a patch. > > Cheers.. > Akshay >
That patch looks good to me. It might also be good to print the extension id in missing feature log. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
