Fix 'kernel_str' memory leak and check for the right pointer.
CC: [email protected]
Bug-Id: CID 739878 / CID 739882
---
libavfilter/vf_libopencv.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavfilter/vf_libopencv.c b/libavfilter/vf_libopencv.c
index 1540d8d..cc5b4cb 100644
--- a/libavfilter/vf_libopencv.c
+++ b/libavfilter/vf_libopencv.c
@@ -261,7 +261,7 @@ static av_cold int dilate_init(AVFilterContext *ctx, const
char *args)
OCVContext *s = ctx->priv;
DilateContext *dilate = s->priv;
char default_kernel_str[] = "3x3+0x0/rect";
- char *kernel_str;
+ char *kernel_str = NULL;
const char *buf = args;
int ret;
@@ -269,11 +269,12 @@ static av_cold int dilate_init(AVFilterContext *ctx,
const char *args)
if (args)
kernel_str = av_get_token(&buf, "|");
- if ((ret = parse_iplconvkernel(&dilate->kernel,
- *kernel_str ? kernel_str :
default_kernel_str,
- ctx)) < 0)
- return ret;
+ ret = parse_iplconvkernel(&dilate->kernel,
+ kernel_str ? kernel_str : default_kernel_str,
+ ctx);
av_freep(&kernel_str);
+ if (ret < 0)
+ return ret;
sscanf(buf, "|%d", &dilate->nb_iterations);
av_log(ctx, AV_LOG_VERBOSE, "iterations_nb:%d\n", dilate->nb_iterations);
--
1.9.3 (Apple Git-50)
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
