On Sun, Jan 25, 2015 at 7:54 AM, Diego Biurrun <[email protected]> wrote:

> On Sat, Jan 24, 2015 at 03:14:05PM +0100, Hendrik Leppkes wrote:
> > --- a/libavcodec/hevc_refs.c
> > +++ b/libavcodec/hevc_refs.c
> > @@ -340,6 +354,7 @@ static HEVCFrame *generate_missing_ref(HEVCContext
> *s, int poc)
> >
> > +    if (!s->avctx->hwaccel) {
> >      if (!s->sps->pixel_shift) {
> >          for (i = 0; frame->frame->buf[i]; i++)
> >              memset(frame->frame->buf[i]->data, 1 << (s->sps->bit_depth
> - 1),
>
> Maybe use && here and save the reindent?
>

There is both the if and else block which must not run with a hwaccel, and
personally I don't like  if (.. && !hwaccel) ... else if (!hwaccel)...
If it was a single if block, I would've added it to the condition.

- Hendrik
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to