Hello Christophe,

> > +static void g722_apply_qmf(const int16_t *prev_samples, int *xout1, int 
> > *xout2)
> > +{
> > +    int i;
> > +
> > +    *xout1 = 0;
> > +    *xout2 = 0;
> > +    for (i = 0; i < 12; i++) {
> > +        MAC16(*xout2, prev_samples[2*i  ], qmf_coeffs[i   ]);
> > +        MAC16(*xout1, prev_samples[2*i+1], qmf_coeffs[11-i]);
> > +    }
> > +}
> 
> I would have sweared there were already dsp functions for this, but it
> turns out it's not the case:
> - scalarproduct_and_madd_int16 (from apedsp) does a lot more that is
> needed here;
> - the actual only scalar product is for float at the moment.
> 
> Well, as long as only one codec uses that form, ok.
> 
> Note: scalarproduct_and_madd_int16 can be used in wmalosslessdec
> (making it no longer an apedsp only thing), but no idea nor interest
> in the status of the libav patch.

thanks you for pointing out similar code

a subsequent patch in the series inlines the G722 QMF coefficient 
constants into the code making it non-generic

thanks, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to