On Mon, Jan 26, 2015 at 11:28:55AM +0100, Anton Khirnov wrote:
> Quoting Alex Converse (2015-01-25 08:14:10)
> > On Jan 24, 2015 10:44 PM, "Diego Biurrun" <[email protected]> wrote:
> > > On Thu, Jan 22, 2015 at 11:04:41AM -0800, Alex Converse wrote:
> > > > --- a/libavcodec/Makefile
> > > > +++ b/libavcodec/Makefile
> > > > @@ -91,7 +91,8 @@ OBJS-$(CONFIG_WMA_FREQS)               += wma_freqs.o
> > > >  OBJS-$(CONFIG_AAC_DECODER)             += aacdec.o aactab.o aacsbr.o
> > aacps.o \
> > > > -                                          aacadtsdec.o mpeg4audio.o
> > kbdwin.o \
> > > > +                                          aacadtsdec.o opus_imdct.o \
> > > > +                                          mpeg4audio.o kbdwin.o \
> > > >                                            sbrdsp.o aacpsdsp.o
> > > > --- a/libavcodec/aac.h
> > > > +++ b/libavcodec/aac.h
> > > > @@ -32,6 +32,7 @@
> > > >  #include "libavutil/float_dsp.h"
> > > >  #include "avcodec.h"
> > > > +#include "opus_imdct.h"
> > > >  #include "fft.h"
> > >
> > > Maybe this IMDCT should be renamed to something else now?
> > > It's obviously not specific to Opus ...
> > 
> > Currently it can't even seem to decide if it wants to be called the celt
> > imdct or the opus imdct. Maybe imdct15 would be a better name. It would
> > also be nice if I could call it from the same interface as the 2**n imdct.
> 
> Yes, sorry, I didn't give it sufficient thought at the time.
> Feel free to rename it to imdct15.

I'll send a patch to do that later.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to