On Mon, 2 Feb 2015, Diego Biurrun wrote:
On Sun, Feb 01, 2015 at 05:26:26PM +0200, Martin Storsjö wrote:
This fixes builds with vc1_parser enabled without vc1_decoder. All
the vc1_decoder object files were included in the vc1_parser line
in libavcodec/Makefile before, but architecture specific object files
for vc1_decoder were not.
---
configure | 2 +-
libavcodec/Makefile | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
I'm sceptical that this is the right solution. What is common to both
components? Whatever it is should be factored out into a separate
file.
It calls ff_vc1_init_common and a bunch of other shared vc1 routines. Yes,
I did try to do a 5 minute check if it would be trivially fixable
otherwise, but no, it's not (at least without risking breaking it
severely).
I'm aware that this might entail fighting the hairy mpeg spaghetti
monster. In that case I could live with this if there was a FIXME
comment or a bug report in an appropriate place to mark this as
the workaround that it is.
The h264_parser also depends on h264_decoder, just a few lines up. Should
we add a fixme for that as well?
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
