Am 05.02.2015 um 10:03 schrieb Diego Biurrun:
> On Wed, Feb 04, 2015 at 09:27:41AM +0100, Oleksij Rempel wrote:
>> --- a/Changelog
>> +++ b/Changelog
>> @@ -12,6 +12,7 @@ version <next>:
>> - VP8 in Ogg demuxing
>> - OpenH264 encoder wrapper
>> - Support DNx100 (960x720@8)
>> +- DSS_SP decoder
>
> "DSS SP" I guess.
>
>> --- a/libavcodec/codec_desc.c
>> +++ b/libavcodec/codec_desc.c
>> @@ -2202,6 +2202,13 @@ static const AVCodecDescriptor codec_descriptors[] = {
>> {
>> + .id = AV_CODEC_ID_DSS_SP,
>> + .type = AVMEDIA_TYPE_AUDIO,
>> + .name = "dss_sp",
>> + .long_name = NULL_IF_CONFIG_SMALL("DSS SP"),
>
> This should spell out the abbreviation IMO.
>
> What does SP stand for anyway?
>
>> --- /dev/null
>> +++ b/libavcodec/dss_sp.c
>> @@ -0,0 +1,784 @@
>> +/*
>> + * dss_sp audio decoder
>
> same
>
>> +#include "libavutil/common.h"
>> +#include "libavutil/channel_layout.h"
>> +#include "libavutil/mem.h"
>> +#include "libavutil/opt.h"
>> +
>> +#include "avcodec.h"
>> +#include "internal.h"
>> +#include "get_bits.h"
>
> nit: order
>
>> +typedef struct LPCData {
>> + int32_t filter[14];
>> +} LPCData;
>
> Why do you wrap the array in a struct?
>
>> +typedef struct DssSpContext {
>> + int32_t excitation[288 + 6];
>> + int32_t history[187];
>> + DssSpFrame fparam;
>> + int32_t working_buffer[SUBFRAMES][72];
>> + int32_t audio_buf[15];
>> + int32_t err_buf1[15];
>> + LPCData lpc;
>> + int32_t filter[15];
>> + int32_t vector_buf[72];
>> + int noise_state;
>> + int32_t err_buf2[15];
>
> These array sizes seem slightly magicky to me.Most of notices i addresses except of this one. Suddenly i can't demystify this numbers, st least now - chronic lack of time :( Are you ok to close on this one eye? :D -- Regards, Oleksij
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
