On Thu, 12 Feb 2015 14:31:10 +0100
Hendrik Leppkes <[email protected]> wrote:

> On Thu, Feb 12, 2015 at 10:54 AM, Anton Khirnov <[email protected]> wrote:
> > ---
> >  avconv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/avconv.c b/avconv.c
> > index 8e76863..6349cae 100644
> > --- a/avconv.c
> > +++ b/avconv.c
> > @@ -1276,7 +1276,6 @@ static int decode_video(InputStream *ist, AVPacket 
> > *pkt, int *got_output)
> >
> >      decoded_frame->pts = guess_correct_pts(&ist->pts_ctx, 
> > decoded_frame->pkt_pts,
> >                                             decoded_frame->pkt_dts);
> > -    pkt->size = 0;
> >
> >      if (ist->st->sample_aspect_ratio.num)
> >          decoded_frame->sample_aspect_ratio = ist->st->sample_aspect_ratio;
> 
> 
> While this change itself is not wrong, I would like to question the
> requirement for it.
> All video decoders to-date can get by without this, and it greatly
> simplifies the API - plus practically no implementation will support
> it.
> 
> So, if possible at all, can the mfx code handle this internally and we
> not start requiring this handling for the video decode API as well?
> 

+1

Better not add exceptions to the generic API just to get something very
obscure to work.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to