On 02/15/2015 06:40 PM, Himangi Saraogi wrote:
@@ -646,19 +646,19 @@ int ff_msmpeg4_decode_block(MpegEncContext * s, int16_t *
block,
if (level < 0){
av_log(s->avctx, AV_LOG_ERROR, "dc overflow- block: %d qscale:
%d//\n", n, s->qscale);
if(s->inter_intra_pred) level=0;
- else return -1;
+ else return level;
}
This looks like an overloaded return value. It could be overflow for the
level value or an error code. I would recommend making
msmpeg4_decode_dc() take a pointer to level as an output param and
return only an error code.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
