On Wed, Feb 18, 2015 at 08:57:09PM +0100, Peter Meerwald wrote:
> --- /dev/null
> +++ b/libavresample/arm/asm-offsets.h
> @@ -0,0 +1,28 @@
> +
> +#ifndef AVRESAMPLE_ARM_ASM_OFFSETS_H
> +#define AVRESAMPLE_ARM_ASM_OFFSETS_H
> +
> +/* struct ResampleContext */
> +#define FILTER_BANK 0x08
> +#define FILTER_LENGTH 0x0c
> +#define SRC_INCR 0x20
> +#define PHASE_SHIFT 0x28
> +#define PHASE_MASK (PHASE_SHIFT + 0x04)
> +#endif /* AVRESAMPLE_ARM_ASM_OFFSETS_H */
nit: Add an empty line before the endif.
> --- /dev/null
> +++ b/libavresample/arm/resample_init.c
> @@ -0,0 +1,69 @@
> +
> +#include "config.h"
> +#include "libavutil/cpu.h"
> +#include "libavutil/arm/cpu.h"
> +#include "libavutil/internal.h"
> +#include "libavutil/samplefmt.h"
> +#include "libavresample/resample.h"
nit: order, leave an empty line between library blocks
> +void ff_audio_resample_init_arm(ResampleContext *c,
> + enum AVSampleFormat sample_fmt)
av_cold
> + switch (sample_fmt) {
> + case AV_SAMPLE_FMT_FLTP:
> + c->resample_one = c->linear ? ff_resample_linear_flt_neon :
> ff_resample_one_flt_neon;
> + break;
IIRC the other init functions use if-else blocks in such cases.
> --- /dev/null
> +++ b/libavresample/arm/resample_neon.S
> @@ -0,0 +1,357 @@
> +
> +#include "libavutil/arm/asm.S"
> +#include "asm-offsets.h"
nit: empty line between library blocks
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
