On Fri, Feb 20, 2015 at 10:43 AM, Martin Storsjö <mar...@martin.st> wrote:
> On Fri, 20 Feb 2015, Vittorio Giovara wrote:
>
>> On Thu, Feb 19, 2015 at 3:34 PM, Martin Storsjö <mar...@martin.st> wrote:
>>>
>>> ---
>>> libavformat/rtpdec_h264.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c
>>> index 8dab0d2..5b87529 100644
>>> --- a/libavformat/rtpdec_h264.c
>>> +++ b/libavformat/rtpdec_h264.c
>>> @@ -208,6 +208,7 @@ static int h264_handle_packet_stap_a(AVFormatContext
>>> *ctx, AVPacket *pkt,
>>> } else {
>>> av_log(ctx, AV_LOG_ERROR,
>>> "nal size exceeds length: %d %d\n", nal_size,
>>> src_len);
>>> + return AVERROR_INVALIDDATA;
>>> }
>>>
>>> // eat what we handled
>>
>>
>> Do you think you could just add one line in the commit log mentioning
>> the reason for the change?
>
>
> Something like this? "Previously, errors were only logged but the code kept
> on trying, and never actually returning the error as a return value."
yeah, looks nice
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
