On 02/23/2015 07:47 AM, Diego Biurrun wrote:
On Mon, Feb 23, 2015 at 11:38:01AM +0100, Gwenole Beauchesne wrote:
2015-02-23 2:49 GMT+01:00 Himangi Saraogi <[email protected]>:
--- a/libavcodec/vaapi_h264.c
+++ b/libavcodec/vaapi_h264.c
@@ -95,7 +95,7 @@ static int dpb_add(DPB *dpb, H264Picture *pic)
if (dpb->size >= dpb->max_size)
- return -1;
+ return AVERROR_INVALIDDATA;
@@ -136,13 +136,13 @@ static int
fill_vaapi_ReferenceFrames(VAPictureParameterBufferH264 *pic_param,
for (i = 0; i < h->short_ref_count; i++) {
H264Picture * const pic = h->short_ref[i];
if (pic && pic->reference && dpb_add(&dpb, pic) < 0)
- return -1;
+ return AVERROR_INVALIDDATA;
}
for (i = 0; i < 16; i++) {
H264Picture * const pic = h->long_ref[i];
if (pic && pic->reference && dpb_add(&dpb, pic) < 0)
- return -1;
+ return AVERROR_INVALIDDATA;
}
Those three would be more: "internal error, please report this bug to
XXX" so that we could see how to fix it. Thanks. AVERROR_BUG?
You mean avpriv_request_sample() and AVERROR_PATCHWELCOME?
Those are for known unimplemented features or untested code paths due to
lack of samples. I can't tell for sure, but from the context this does
look more like a case for AVERROR_BUG.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
