Avoid the gerund in the log message title, just use the infinitive. On Mon, Feb 23, 2015 at 05:55:54PM +0000, [email protected] wrote: > From: Federico Tomassetti <[email protected]> > > ff_mergeable_formats is as a wrapper around ff_merge_formats aiming to avoid > memory leaks > currently present
s/is as/is/ currently present memory leaks. Please keep lines in log messages below 80 characters where easily possible. > --- a/libavfilter/avfiltergraph.c > +++ b/libavfilter/avfiltergraph.c > @@ -300,7 +300,7 @@ static int query_formats(AVFilterGraph *graph, AVClass > *log_ctx) > if (link->in_formats != link->out_formats && > - !ff_merge_formats(link->in_formats, > + !ff_mergeable_formats(link->in_formats, > link->out_formats)) Indentation is off. > --- a/libavfilter/formats.h > +++ b/libavfilter/formats.h > @@ -173,6 +173,11 @@ AVFilterFormats *ff_planar_sample_fmts(void); > > /** > + * Return true if the intersection of the formats of a and b is not empty. > + */ > +int ff_mergeable_formats(AVFilterFormats *a, AVFilterFormats *b); Please also document the parameters, otherwise Doxygen will warn. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
