On Sat, 28 Feb 2015, Luca Barbato wrote:

On 27/02/15 12:00, Martin Storsjö wrote:
This makes the code slightly more readable and understandable.
---
 libavformat/rtpenc_aac.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)


probably using the shift 3 instead of multiply 8 might improve it even more.

Actually, I rather keep it as a multiply by 8 - that way it is IMO a bit clearer that this is a number of bits, not that it is some sort of bitfield (like the way fixed-bit-length fields are written in some packetized headers).

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to