Quoting Diego Biurrun (2015-03-03 21:11:02)
> On Wed, Feb 25, 2015 at 03:28:13PM +0100, Diego Biurrun wrote:
> > ---
> >  libavcodec/dca.c           | 11 ++++++-----
> >  libavcodec/dca.h           |  9 ---------
> >  libavcodec/dca_exss.c      |  1 +
> >  libavcodec/dca_parser.c    |  9 +++++----
> >  libavcodec/dca_syncwords.h | 37 +++++++++++++++++++++++++++++++++++++
> >  libavcodec/dcadec.c        |  7 ++++---
> >  libavformat/dtsdec.c       | 13 +++++--------
> >  libavformat/spdifenc.c     | 11 ++++++-----
> >  8 files changed, 64 insertions(+), 34 deletions(-)
> >  create mode 100644 libavcodec/dca_syncwords.h
> > 
> > --- /dev/null
> > +++ b/libavcodec/dca_syncwords.h
> > @@ -0,0 +1,37 @@
> > +#ifndef AVCODEC_DCA_SYNCWORDS_H
> > +#define AVCODEC_DCA_SYNCWORDS_H
> > +
> > +enum DCASyncwords {
> > +    DCA_SYNCWORD_CORE_BE        = 0x7FFE8001,
> > +    DCA_SYNCWORD_CORE_LE        = 0xFE7F0180,
> > +    DCA_SYNCWORD_CORE_14B_BE    = 0x1FFFE800,
> > +    DCA_SYNCWORD_CORE_14B_LE    = 0xFF1F00E8,
> > +    DCA_SYNCWORD_XCH            = 0x5A5A5A5A,
> > +    DCA_SYNCWORD_XXCH           = 0x47004A03,
> > +    DCA_SYNCWORD_X96            = 0x1D95F262,
> > +    DCA_SYNCWORD_XBR            = 0x655E315E,
> > +    DCA_SYNCWORD_LBR            = 0x0A801921,
> > +    DCA_SYNCWORD_XLL            = 0x41A29547,
> > +    DCA_SYNCWORD_SUBSTREAM      = 0x64582025,
> > +    DCA_SYNCWORD_SUBSTREAM_CORE = 0x02B09261,
> > +};
> > +
> > +#endif /* AVCODEC_DCA_SYNCWORDS_H */
> 
> I'm toying with the idea of moving this to libavutil instead to reduce the
> coupling between libavformat and libavcodec.  Thoughts?

By increasing the lavf/lavu and lavc/lavu couplings.

I don't see a problem, as long as those are just enums.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to