On Mon, 9 Mar 2015, Luca Barbato wrote:
On 20/01/15 16:00, Martin Storsjö wrote:
This way, the caller doesn't need to coordinate setting the option
after the moov atom has been written. The downside is that it is
no longer possible to use the option for checking whether the moov
atom already has been written, but a caller is able to keep track
of that by other means anyway.
Which means? The patch seems fine beside that.
Previously, the field fragment_index was used to say that "if
fragment_index == 0, we haven't yet written the moov, and we should do
that". This meant that if you set fragment_index to a nonzero value before
write_header, things were screwed up (and you potentially didn't get any
moov written at all, or other weird things). Now we have two separate
variables, a moov_written flag, and the fragment_index. So now we can set
fragment_index at any time, but we can't read it in order to check "has
the moov been written yet?". (But it wasn't ever officially meant to be
used for that either, nor was that functionality described, so I doubt
anybody would do that.)
Btw, thanks for the review - this patch also has got a 1/2 from January
that needs an ack.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
