Hi Andreas,

On Mon, 9 Mar 2015, Andreas Cadhalpun wrote:

Hi,

trying to encode e.g. codec bmp with format rtp_mpegts crashes, because the avformat_write_header failure isn't handled correctly.
Attached is a patch fixing this.

Thanks for the patch, and thanks for finding the issue.

You're quite correct that the error handling here is broken, but I'm not able to reproduce it by trying to mux bmp into this muxer - that actually succeeds.

Would you mind sending the patches inline - that would ease review of them.

Your patch causes avformat_write_trailer to be called, even if avformat_write_header failed - that's not the right way to handle it. I'll send a new version of the patch that handles it correctly.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to