On Tue, Mar 10, 2015 at 11:32 AM, wm4 <[email protected]> wrote: > On Tue, 10 Mar 2015 01:28:52 +0000 > Vittorio Giovara <[email protected]> wrote: > >> --- >> libavcodec/utils.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/utils.c b/libavcodec/utils.c >> index d568cbb..f8a8908 100644 >> --- a/libavcodec/utils.c >> +++ b/libavcodec/utils.c >> @@ -1050,7 +1050,10 @@ int attribute_align_arg avcodec_open2(AVCodecContext >> *avctx, const AVCodec *code >> >> entangled_thread_counter++; >> if (entangled_thread_counter != 1) { >> - av_log(avctx, AV_LOG_ERROR, "insufficient thread locking around >> avcodec_open/close()\n"); >> + av_log(avctx, AV_LOG_ERROR, >> + "Insufficient thread locking around avcodec_open2(). " >> + "At least %d threads are running at the same time right >> now.\n", >> + entangled_thread_counter); >> ret = -1; >> goto end; >> } > > Uh, this error message is not much better. > > How about: "lavc is not thread-safe, you are fucked." > > Or maybe add actual internal locking (instead of forcing the user to > use this infernal lock manager abomination), and change it to > "recursive codec opening not supported".
Good idea, patch is welcome :) -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
