On Thu, Mar 26, 2015 at 2:27 PM, Diego Biurrun <[email protected]> wrote:
> On Sun, Mar 22, 2015 at 03:49:50PM +0000, Vittorio Giovara wrote:
>> +#include "libavutil/imgutils.h"
>> +#include "libavutil/intreadwrite.h"
>> +
>> +#include "avcodec.h"
>> +#include "internal.h"
>> +
>> +#include "hq_hqa.h"
>> +
>> +// AAN IDCT
>
> Does this match the DCT we have?

No it's a semi custom one. I'll describe better in a comment.

>> --- /dev/null
>> +++ b/libavcodec/hqdata.c
>> @@ -0,0 +1,8374 @@
>> +    247, -247, 248, -248, 249, -249, 250, -250,
>> +    251, -251, 252, -252, 253, -253, 254, -254,
>> +    255, -255,
>> +};
>> +static const uint8_t hq_tab_01[] = {
>> +    0,   0, 12,  3, 20,  0, 28,  3, 40,  0,  0, 10, 15,  6, 20,
>> +    10, 35,  6, 40, 10,  7, 13, 15, 16, 23, 13, 35, 16, 39, 13,
>> +    7,  23, 10, 19, 23, 23, 27, 20, 39, 23,  2, 26, 10, 29, 22,
>
> missing empty line

I didn't add it to group this category of tables, should they still be
separated?

> Note that the hq_tab_* tables would look better if the first column was
> also right-aligned, like the rest, and not left-aligned.

I agree, but I couldn't find an uncrustify config that would do that.
Do you know how to do that?
No, I am not going to process each table manually :-p
-- 
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to