On 14/04/15 12:37, Diego Biurrun wrote: > On Fri, Apr 10, 2015 at 10:25:28AM -0700, Timothy Gu wrote: >> --- >> >> The samples are all from https://samples.libav.org/A-codecs/ATRAC3%2b/. >> Should I upload the .pcm files to somewhere? They are trivial enough to >> reproduce. > > make fate GEN=1 should create them.
Would be nice that once created they are uploaded on the ftp and then moved to the fate repository, in other news I'd move the fate samples to git-lfs to simplify its management. >> --- a/tests/fate/atrac.mak >> +++ b/tests/fate/atrac.mak >> @@ -16,11 +16,22 @@ fate-atrac3-3: REF = >> $(SAMPLES)/atrac3/mc_sich_at3_132_small.pcm >> >> -FATE_ATRAC_ALL = $(FATE_ATRAC1-yes) $(FATE_ATRAC3-yes) >> +FATE_ATRAC3P += fate-atrac3p-1 >> +fate-atrac3p-1: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/at3p_sample1.oma >> +fate-atrac3p-1: REF = $(SAMPLES)/atrac3p/at3p_sample1.pcm >> + >> +FATE_ATRAC3P += fate-atrac3p-2 >> +fate-atrac3p-2: CMD = pcm -i $(TARGET_SAMPLES)/atrac3p/sonateno14op27-2.aa3 >> +fate-atrac3p-2: REF = $(SAMPLES)/atrac3p/sonateno14op27-2.pcm > > Why did you pick these two samples? > They provide the best coverage. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
